FullStack Developer
Creative thinking
1x
2 Issues Created
2x
16 Issues Created
3x
128 Issues Created
4x
1024 Issues Created
Problem Solving
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Practical/Professional Skills
Communication Skills
1x
100th Community Interaction
2x
1000th Community Interaction
3x
10000th Community Interaction
Collaboration
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Community Engagement
1x
100 Activity Points
2x
1000 Activity Points
3x
10000 Activity Points
Leadership
1x
Promoted to a team leader
Learn How to Learn
1x
Completed the course work
Skills to apply digital & technology solutions
1x
1 Project Completed Successfully
2x
2 Projects Completed Successfully
3x
3 Projects Completed Successfully
Critical Thinking
Autonomy And Responsibility
1x
2 issues identified and resolved
2x
16 issues identified and resolved
3x
128 issues identified and resolved
4x
1024 issues identified and resolved
Empathy
Value inculcation
Multicultural Competence
Individual Skills
Creative thinking
Problem Solving
Practical/Professional Skills
Team Skills
Communication Skills
Collaboration
Community Engagement
Leadership
Learn How to Learn
Skills to apply digital & technology solutions
Critical Thinking
Advanced Skills
Autonomy And Responsibility
Empathy
Value inculcation
Multicultural Competence
Cultural Skills
Shared a comment on a pull request in coronasafe/care on December 7, 2023 at 9:34:09 PM
Writes already had AuthZ as well.
https://github.com/coronasafe/care/pull/1704#issuecomment-1846145627
Shared a comment on an issue in coronasafe/care on December 7, 2023 at 6:18:07 PM
Yeah, we can take it out, it serves no purpose now ( To be frank i don't think it ever served any purpose 😅 )
https://github.com/coronasafe/care/issues/1551#issuecomment-1845879214
Shared a comment on a pull request in coronasafe/care on December 7, 2023 at 6:10:11 PM
Resolve Conflicts.
https://github.com/coronasafe/care/pull/1728#issuecomment-1845868105
Shared a comment on a pull request in coronasafe/care on December 7, 2023 at 5:53:58 PM
Caution!, This needs to be mentioned in the release note.
https://github.com/coronasafe/care/pull/1703#issuecomment-1845843560
Shared a comment on a pull request in coronasafe/care on December 7, 2023 at 5:52:38 PM
https://github.com/coronasafe/care/pull/1704/files#diff-855ccb735aeda2b9a06ef57530782964236126df0b0ff032ddb451c6e9046945R65 AuthZ is already present
https://github.com/coronasafe/care/pull/1704#issuecomment-1845841667
Shared a comment on a pull request in coronasafe/care on November 2, 2023 at 2:05:06 PM
@sainak review required
https://github.com/coronasafe/care/pull/1690#issuecomment-1790801784
Shared a comment on a pull request in coronasafe/care on October 31, 2023 at 8:46:17 AM
This PR is probably causing me to age a bit faster :/
https://github.com/coronasafe/care/pull/1678#issuecomment-1786760685
Shared a comment on a pull request in coronasafe/care on October 20, 2023 at 11:52:06 AM
Tests failing
https://github.com/coronasafe/care/pull/1678#issuecomment-1772594818
Shared a comment on a pull request in coronasafe/care on October 16, 2023 at 1:07:30 PM
Closing stale MR
https://github.com/coronasafe/care/pull/1553#issuecomment-1764449608
Shared a comment on a pull request in coronasafe/care on October 16, 2023 at 12:56:55 PM
I don't really see a use for this. how are users going to be added in the M2M model?
https://github.com/coronasafe/care/pull/1264#issuecomment-1764429991
Shared a comment on a pull request in coronasafe/care on September 28, 2023 at 4:51:30 PM
Closing because this is unrelated to Care, I provided an SQL dump to @mathew-alex for reference in metabase
https://github.com/coronasafe/care/pull/1644#issuecomment-1739688674
Shared a comment on a pull request in coronasafe/care on September 19, 2023 at 5:17:35 PM
You also need to create a signal to delete the cache when an asset updates, need tests for that edge as well.
https://github.com/coronasafe/care/pull/1625#issuecomment-1726149220
Shared a comment on a pull request in coronasafe/care on September 12, 2023 at 6:19:45 AM
Resolve conflicts
https://github.com/coronasafe/care/pull/1596#issuecomment-1715057821
Shared a comment on a pull request in coronasafe/care on September 11, 2023 at 3:01:10 PM
cc @mathew-alex
https://github.com/coronasafe/care/pull/1583#issuecomment-1714067434
Shared a comment on a pull request in coronasafe/care on August 29, 2023 at 1:46:15 PM
Make sure you add some make commands that lint currently staged and all files ( both with and without docker )
https://github.com/coronasafe/care/pull/1559#issuecomment-1697478957
Shared a comment on a pull request in coronasafe/care on August 29, 2023 at 1:42:52 PM
I can merge once tests have been added
https://github.com/coronasafe/care/pull/1565#issuecomment-1697473317
Shared a comment on a pull request in coronasafe/care on August 25, 2023 at 9:09:55 AM
set a hard limit on the page size
https://github.com/coronasafe/care/pull/1557#issuecomment-1693036840
Shared a comment on a pull request in coronasafe/care on August 21, 2023 at 1:38:59 PM
Creating some superuser would also be a good idea.
https://github.com/coronasafe/care/pull/1536#issuecomment-1686350412
Shared a comment on a pull request in coronasafe/care on August 21, 2023 at 10:47:39 AM
Need Tests!
https://github.com/coronasafe/care/pull/1535#issuecomment-1686093330
Shared a comment on a pull request in coronasafe/care on August 13, 2023 at 7:10:22 PM
@gigincg @aparnacoronasafe This change requires an ops review as well.
https://github.com/coronasafe/care/pull/1507#issuecomment-1676439412
Shared a comment on a pull request in coronasafe/care on August 8, 2023 at 6:44:30 PM
@rithviknishad @sainak review.
https://github.com/coronasafe/care/pull/1093#issuecomment-1670120070
Shared a comment on a pull request in coronasafe/care on August 8, 2023 at 6:39:06 PM
@rithviknishad add your review.
https://github.com/coronasafe/care/pull/1277#issuecomment-1670114105
Shared a comment on a pull request in coronasafe/care on August 8, 2023 at 6:38:45 PM
Failing tests.
https://github.com/coronasafe/care/pull/1277#issuecomment-1670113714
Shared a comment on a pull request in coronasafe/care on August 8, 2023 at 6:38:30 PM
Squash all migrations to a single one.
https://github.com/coronasafe/care/pull/1277#issuecomment-1670113432
Shared a comment on a pull request in coronasafe/care on August 8, 2023 at 6:21:26 PM
Switch to https://docs.djangoproject.com/en/4.2/ref/models/fields/#positiveintegerfield
https://github.com/coronasafe/care/pull/1505#issuecomment-1670092976
Shared a comment on a pull request in coronasafe/care on August 4, 2023 at 1:55:12 PM
Merging without Reviewing
https://github.com/coronasafe/care/pull/1510#issuecomment-1665649429
Shared a comment on a pull request in coronasafe/care on August 4, 2023 at 7:26:41 AM
Testing if pipeline succeeds on no missing migrations
https://github.com/coronasafe/care/pull/1509#issuecomment-1665136401
Shared a comment on a pull request in coronasafe/care on July 20, 2023 at 7:32:49 PM
All endpoints with ``` permission_classes = (AllowAny,) authentication_classes = [ABDMAuthentication] ``` needs to be changed
https://github.com/coronasafe/care/pull/1457#issuecomment-1644484498
Shared a comment on a pull request in coronasafe/care on July 20, 2023 at 4:02:22 PM
@yaswanthsaivendra Good Job! Sorry for the late review!
https://github.com/coronasafe/care/pull/1370#issuecomment-1644193204
Shared a comment on a pull request in coronasafe/care on July 18, 2023 at 2:07:43 PM
Looks good to me, two things to note, maybe these can be made as issues, - Make sure that the request to any external API's have a timeout and its reasonable - Instead of one long celery job to monitor each asset, the master job could spin off multiple jobs per asset that are performed asynchronously, the checks themselves need not be serial.
https://github.com/coronasafe/care/pull/1454#issuecomment-1640300060
Shared a comment on a pull request in coronasafe/care on July 7, 2023 at 9:21:23 AM
@sainak review and merge.
https://github.com/coronasafe/care/pull/1441#issuecomment-1625118926
Shared a comment on a pull request in coronasafe/care on July 5, 2023 at 9:53:25 AM
@sainak can you review these changes?
https://github.com/coronasafe/care/pull/1370#issuecomment-1621425878
Shared a comment on a pull request in coronasafe/care on July 5, 2023 at 9:52:48 AM
> @vigneshhari this is a good time to migrate and remove `referred_to` foreign key > > https://github.com/coronasafe/care/blob/b0eefd152511a390f759b41dac0cb7e27c9ee117/care/facility/models/patient_consultation.py#L92-L98 This is more of an ops question @gigincg
https://github.com/coronasafe/care/pull/1430#issuecomment-1621424832
Shared a comment on a pull request in coronasafe/care on July 5, 2023 at 9:51:43 AM
@sainak can you separate it out, we can merge it right away.
https://github.com/coronasafe/care/pull/1431#issuecomment-1621423040
Shared a comment on a pull request in coronasafe/care on July 3, 2023 at 7:44:42 AM
@rithviknishad Need to fix tests.
https://github.com/coronasafe/care/pull/1415#issuecomment-1617551677
Shared a comment on a pull request in coronasafe/care on July 1, 2023 at 2:19:28 PM
Tests Failing
https://github.com/coronasafe/care/pull/1416#issuecomment-1615937539
Shared a comment on a pull request in coronasafe/care on June 21, 2023 at 8:08:33 AM
Closing Stale PR since there are no updates for a week.
https://github.com/coronasafe/care/pull/1368#issuecomment-1600385288
Shared a comment on a pull request in coronasafe/care on June 20, 2023 at 9:46:12 AM
@mathew-alex can you add the data to the env ? i am merging this MR.
https://github.com/coronasafe/care/pull/1390#issuecomment-1598459999
Shared a comment on a pull request in coronasafe/care on June 13, 2023 at 7:22:55 AM
@sainak can you link the corresponding FE PR as well, since the API contract changes we would need to merge the FE PR as well.
https://github.com/coronasafe/care/pull/1303#issuecomment-1588698846
Shared a comment on an issue in coronasafe/care on June 12, 2023 at 12:09:06 PM
> @gigincg it's a nice to have, chrome is closed sourced, vignesh tried using chromium but that didnt work either. FYI Chromium is now implemented.
https://github.com/coronasafe/care/issues/812#issuecomment-1587209814
Shared a comment on a pull request in coronasafe/care on June 11, 2023 at 12:08:42 PM
Can i get an ops confirmation for this? This would remove all historical data for this field. cc @gigincg @aparnacoronasafe
https://github.com/coronasafe/care/pull/1309#issuecomment-1586138328
Shared a comment on an issue in coronasafe/care on June 11, 2023 at 11:50:53 AM
Current unit tests work as expected and run successfully in GitHub actions, but they test little to nothing, you can treat this as an EPIC and create sub-tickets for each module and add tests for them. We need to test all edge cases and all authorization edges. Lemme know if you need to discuss this over a call.
https://github.com/coronasafe/care/issues/1367#issuecomment-1586133299
Shared a comment on a pull request in coronasafe/care on June 11, 2023 at 10:43:58 AM
could you move all the syncing bits to a common utility function, in the future we would want a task running once a day to calculate drift, correct it, and report it. Think of a common framework since we would have a lot of these caches
https://github.com/coronasafe/care/pull/1349#issuecomment-1586111071
Shared a comment on an issue in coronasafe/care on June 11, 2023 at 10:41:00 AM
@GeekGawd if you are working on the issue, lemme know, I'll assign it to you
https://github.com/coronasafe/care/issues/1339#issuecomment-1586110496
Shared a comment on an issue in coronasafe/care on June 11, 2023 at 10:40:25 AM
you could prefetch some data and then use signals to cache the property data to ensure that everything works with a single query
https://github.com/coronasafe/care/issues/1339#issuecomment-1586110355
Shared a comment on a pull request in coronasafe/care on April 23, 2023 at 8:49:27 AM
Move Exception to BaseException and remove unused variables/imports/unused f strings. I will fix the rest of them.
https://github.com/coronasafe/care/pull/1258#issuecomment-1518998056
Shared a comment on a pull request in coronasafe/care on April 23, 2023 at 8:48:06 AM
@rithviknishad we need to fix those as well 😓 otherwise we can't use the pipeline to ensure that the code is in the right format all the time
https://github.com/coronasafe/care/pull/1258#issuecomment-1518997658
Shared a comment on a pull request in coronasafe/care on April 21, 2023 at 8:29:39 AM
Fix conflicts
https://github.com/coronasafe/care/pull/1229#issuecomment-1517470474
Shared a comment on a pull request in coronasafe/care on April 17, 2023 at 4:52:47 PM
Make sure this is not used in any relations to any existing models, @rithviknishad a warning like so in the models would be helpful.
https://github.com/coronasafe/care/pull/1234#issuecomment-1511737941
Shared a comment on a pull request in coronasafe/care on April 17, 2023 at 4:10:53 PM
This might add a bit more stress on the database, create a ticket to summarise both counts at the facility level with signals. I will merge this in to keep you folks unblocked.
https://github.com/coronasafe/care/pull/1223#issuecomment-1511677337
Shared a comment on a pull request in coronasafe/care on April 17, 2023 at 4:07:35 PM
Changes look good, Just confirm if the filter is case sensitive, We want it case insensitive.
https://github.com/coronasafe/care/pull/1231#issuecomment-1511669318
Shared a comment on a pull request in coronasafe/care on April 17, 2023 at 3:58:32 PM
The pipelines are still failing @rithviknishad
https://github.com/coronasafe/care/pull/1258#issuecomment-1511648609
Shared a comment on a pull request in coronasafe/care on March 21, 2023 at 4:54:50 PM
Thanks @rithviknishad
https://github.com/coronasafe/care/pull/1225#issuecomment-1478251099
Shared a comment on a pull request in coronasafe/care on March 9, 2023 at 5:25:49 AM
@mathew-alex review and merge
https://github.com/coronasafe/care/pull/1211#issuecomment-1461308297
Shared a comment on a pull request in coronasafe/care on February 18, 2023 at 5:40:06 PM
if requesting user has permission to the selected user, do we need to check anything else?
https://github.com/coronasafe/care/pull/1194#issuecomment-1435724913
Shared a comment on a pull request in coronasafe/care on February 5, 2023 at 3:45:06 PM
You are deleting all skills here, only duplicates have to be deleted, this inadvertently deletes all user-skill objects
https://github.com/coronasafe/care/pull/1176#issuecomment-1418064334
Shared a comment on a pull request in coronasafe/care on January 22, 2023 at 9:51:51 AM
This PR will be marked stale and closed within the next 2 days.
https://github.com/coronasafe/care/pull/1106#issuecomment-1399442539
Shared a comment on a pull request in coronasafe/care on January 22, 2023 at 9:50:59 AM
Filtering users by facility involves the use of "not-so-clean" SQL queries, we already have a facility users list API, and we can use that API to show the users from a given facility if needed. maybe as a separate UI page.
https://github.com/coronasafe/care/pull/1160#issuecomment-1399442402
Shared a comment on a pull request in coronasafe/care on January 21, 2023 at 1:30:26 PM
I would make this a separate api view, maybe under the facilities detailed view
https://github.com/coronasafe/care/pull/1160#issuecomment-1399252144
Shared a comment on a pull request in coronasafe/care on January 13, 2023 at 7:39:41 AM
Can you create another issue to move the discharge view to use a serializer? it was a rather simple view, now that it's complicated, i recommend using a serializer.
https://github.com/coronasafe/care/pull/1155#issuecomment-1381427807
Shared a comment on a pull request in coronasafe/care on January 10, 2023 at 3:49:18 PM
Are we no longer pointing to local if a middleware address is not present?
https://github.com/coronasafe/care/pull/1144#issuecomment-1377473479
Shared a comment on a pull request in coronasafe/care on December 29, 2022 at 4:47:16 AM
Marking stale, will be closed within the next week.
https://github.com/coronasafe/care/pull/860#issuecomment-1367069947
Shared a comment on an issue in coronasafe/care on December 6, 2022 at 4:25:22 PM
Why is this required? We wont proxy any requests in the backend, we will have to populate the values in the tables we have to store geo structures.
https://github.com/coronasafe/care/issues/1107#issuecomment-1339632985
Shared a comment on an issue in coronasafe/care on November 27, 2022 at 5:35:19 AM
We can store a log table to store the ping results, if this data is not needed for long we can keep it in redis. If we choose to use the DB, we can delete it after a given number of days.
https://github.com/coronasafe/care/issues/1108#issuecomment-1328175679
Shared a comment on a pull request in coronasafe/care on November 22, 2022 at 12:18:06 PM
Needs Migrations
https://github.com/coronasafe/care/pull/1101#issuecomment-1323575430
Shared a comment on a pull request in coronasafe/care on November 22, 2022 at 12:17:36 PM
Can we have a validation check in the consultation as well? to not allow file uploads in consultations that have been completed ?
https://github.com/coronasafe/care/pull/1102#issuecomment-1323574910
Shared a comment on a pull request in coronasafe/care on November 1, 2022 at 11:00:41 AM
Any difference in performance ?
https://github.com/coronasafe/care/pull/1085#issuecomment-1298355254
Shared a comment on a pull request in coronasafe/care on October 28, 2022 at 9:08:36 AM
I would rather create a variable and store it in the database, this method fires a query per object retrieval, which can be DB intensive when multiple objects are rendered. @khavinshankar can you create a separate ticket for this. I will approve this on the condition that it will be improved later.
https://github.com/coronasafe/care/pull/1083#issuecomment-1294737068
Shared a comment on a pull request in coronasafe/care on October 7, 2022 at 3:56:13 PM
@mathew-alex make this change in the environment, and close this MR once you are done. @rithviknishad we wont be merging this MR.
https://github.com/coronasafe/care/pull/1056#issuecomment-1271771143
Shared a comment on a pull request in coronasafe/care on October 7, 2022 at 12:22:36 PM
We should also not let them update the archive reason. I believe that was the conclusion from the last call with @aparnacoronasafe , Do confirm before you make this change.
https://github.com/coronasafe/care/pull/1055#issuecomment-1271521319
Shared a comment on a pull request in coronasafe/care on September 27, 2022 at 2:05:20 PM
Please update the docs in another MR or create an issue for it.
https://github.com/coronasafe/care/pull/1037#issuecomment-1259560878
Shared a comment on a pull request in coronasafe/care on September 19, 2022 at 5:33:26 PM
There are no conflicts in the migration as of now.
https://github.com/coronasafe/care/pull/1024#issuecomment-1251330021
Shared a comment on a pull request in coronasafe/care on September 19, 2022 at 5:26:58 PM
Let's not delete any fields immediately; let's keep a leeway of 1 month before deleting any data. remove any migration that deletes the columns.
https://github.com/coronasafe/care/pull/979#issuecomment-1251323139
Shared a comment on a pull request in coronasafe/care on September 14, 2022 at 2:14:09 PM
Can you abstract the methods used to interact with the icd11 objects?
https://github.com/coronasafe/care/pull/1022#issuecomment-1246829375
Shared a comment on a pull request in coronasafe/care on September 10, 2022 at 8:51:17 PM
the model method sounds good enough. make sure you handle the edge cases.
https://github.com/coronasafe/care/pull/1019#issuecomment-1242802904
Shared a comment on a pull request in coronasafe/care on September 10, 2022 at 4:06:12 PM
is #1016 a duplicate of this ?
https://github.com/coronasafe/care/pull/999#issuecomment-1242759999
Shared a comment on a pull request in coronasafe/care on September 2, 2022 at 2:37:19 PM
We decided to create a new field for this, i have already committed these changes to master since this was under high priority. can you add the response to swagger ?
https://github.com/coronasafe/care/pull/995#issuecomment-1235582170
Shared a comment on a pull request in coronasafe/care on August 27, 2022 at 2:25:36 PM
Is this in contrast to the investigations module we already have?
https://github.com/coronasafe/care/pull/990#issuecomment-1229202403
Shared a comment on a pull request in coronasafe/care on August 25, 2022 at 3:19:40 PM
OpenAPI documentation would be nice for this endpoint
https://github.com/coronasafe/care/pull/947#issuecomment-1227409174
Shared a comment on an issue in coronasafe/care on August 23, 2022 at 5:01:57 AM
You can create one.
https://github.com/coronasafe/care/issues/980#issuecomment-1223546458
Shared a comment on an issue in coronasafe/care on August 23, 2022 at 4:50:17 AM
Backend never really built a feature to check if a username is available, this is working on some hack, it was never an intended feature
https://github.com/coronasafe/care/issues/980#issuecomment-1223538691
Shared a comment on an issue in coronasafe/care on August 20, 2022 at 3:20:46 PM
@aparnacoronasafe, a user with the same username exists, this is why the backend threw an error, let's modify this issue to add a cleaner error when this happens. Actual error : `duplicate key value violates unique constraint "users_user_username_key" DETAIL: Key (username)=(james) already exists`
https://github.com/coronasafe/care/issues/980#issuecomment-1221333969
Shared a comment on a pull request in coronasafe/care on August 9, 2022 at 2:23:33 PM
shouldn't we set the end date for the consultation bed as well ?
https://github.com/coronasafe/care/pull/971#issuecomment-1209450244
Shared a comment on a pull request in coronasafe/care on August 9, 2022 at 2:20:26 PM
This data can now be fetched from the current bed object, but that can be a different PR, just keep that in mind.
https://github.com/coronasafe/care/pull/972#issuecomment-1209446188
Shared a comment on an issue in coronasafe/care on July 30, 2022 at 3:45:03 PM
@kunatastic Close this issue if its resolved.
https://github.com/coronasafe/care/issues/907#issuecomment-1200234291
Shared a comment on an issue in coronasafe/care on July 30, 2022 at 3:44:39 PM
Care no longer has PostGIS references.
https://github.com/coronasafe/care/issues/827#issuecomment-1200233792
Shared a comment on an issue in coronasafe/care on July 30, 2022 at 3:43:52 PM
@mathew-alex close if the issue has been resolved.
https://github.com/coronasafe/care/issues/911#issuecomment-1200232864
Shared a comment on an issue in coronasafe/care on July 30, 2022 at 3:43:02 PM
@gigincg can we close this ?
https://github.com/coronasafe/care/issues/937#issuecomment-1200231802
Shared a comment on a pull request in coronasafe/care on July 29, 2022 at 4:02:00 PM
Merge when needed.
https://github.com/coronasafe/care/pull/953#issuecomment-1199618527
Shared a comment on a pull request in coronasafe/care on July 28, 2022 at 6:11:31 PM
All commits will end up being squashed to one, so no worries! Don't let the dark side tempt you! Use the force wisely!!
https://github.com/coronasafe/care/pull/946#issuecomment-1198477023
Shared a comment on a pull request in coronasafe/care on July 28, 2022 at 6:04:43 PM
Why are there no migrations?
https://github.com/coronasafe/care/pull/950#issuecomment-1198467073
Shared a comment on a pull request in coronasafe/care on July 27, 2022 at 3:10:32 AM
@cp-Coder you can use the end_date is null to check if a bed is in use.
https://github.com/coronasafe/care/pull/939#issuecomment-1196215727
Shared a comment on a pull request in coronasafe/care on July 26, 2022 at 2:16:01 PM
ignore the existing values since we cant really do anything in those cases.
https://github.com/coronasafe/care/pull/935#issuecomment-1195543064
Shared a comment on a pull request in coronasafe/care on July 26, 2022 at 2:13:38 PM
do we need an `in_use` attribute ? `end_date == None` serves the same purpose right?
https://github.com/coronasafe/care/pull/939#issuecomment-1195540197
Shared a comment on a pull request in coronasafe/care on July 26, 2022 at 2:08:27 PM
Why the force pushes ?
https://github.com/coronasafe/care/pull/946#issuecomment-1195534034
Shared a comment on a pull request in coronasafe/care on July 16, 2022 at 6:20:30 PM
Do you think that the commits are somehow messed up? i can see changes that were already made in the previous PR
https://github.com/coronasafe/care/pull/923#issuecomment-1186258293
Shared a comment on a pull request in coronasafe/care on July 9, 2022 at 3:30:56 PM
Resolve all conflicts ASAP @cp-Coder
https://github.com/coronasafe/care/pull/876#issuecomment-1179562393
Shared a comment on an issue in coronasafe/care_fe on July 8, 2022 at 12:07:10 PM
@Marmik2003 @skks1212 @Krishna-Sivakumar @sainAk Someone take care of this.
https://github.com/coronasafe/care_fe/issues/2738#issuecomment-1178913472
Shared a comment on a pull request in coronasafe/care on July 8, 2022 at 11:33:33 AM
We can move the excel draw to resources somewhere and make it available as a downloadable
https://github.com/coronasafe/care/pull/917#issuecomment-1178882526
Shared a comment on a pull request in coronasafe/care on July 7, 2022 at 6:49:17 PM
Migrations make no sense, since there are unrelated changes
https://github.com/coronasafe/care/pull/809#issuecomment-1178072370
Shared a comment on a pull request in coronasafe/care on July 3, 2022 at 7:57:42 PM
I need more context, is the API inaccessible from the front-end, i generally do not prefer using the BE as a proxy if it can be performed directly from the FE.
https://github.com/coronasafe/care/pull/864#issuecomment-1173161898
Shared a comment on an issue in coronasafe/care on June 27, 2022 at 8:21:08 PM
@gigincg we had a separate API for this because of the way we store this data internally. The facility user relation is a many-to-many type relation, we can bring in facility filters here but it would not be computationally inefficient. if there is a strong use case for this API, we can start thinking about implementation.
https://github.com/coronasafe/care/issues/785#issuecomment-1167843788
Shared a comment on a pull request in coronasafe/care on June 27, 2022 at 8:08:56 PM
Move tests to a different PR.
https://github.com/coronasafe/care/pull/811#issuecomment-1167831571
Shared a comment on a pull request in coronasafe/care on June 27, 2022 at 8:07:17 PM
wrap around transactions.
https://github.com/coronasafe/care/pull/892#issuecomment-1167830051
Shared a comment on a pull request in coronasafe/care on June 27, 2022 at 8:01:55 PM
Approving without testing.
https://github.com/coronasafe/care/pull/831#issuecomment-1167823393
Shared a comment on an issue in coronasafe/care on June 27, 2022 at 8:21:08 PM
@gigincg we had a separate API for this because of the way we store this data internally. The facility user relation is a many-to-many type relation, we can bring in facility filters here but it would not be computationally inefficient. if there is a strong use case for this API, we can start thinking about implementation.
https://github.com/coronasafe/care/issues/785#issuecomment-1167843788
Shared a comment on a pull request in coronasafe/care on June 27, 2022 at 8:08:56 PM
Move tests to a different PR.
https://github.com/coronasafe/care/pull/811#issuecomment-1167831571
Shared a comment on a pull request in coronasafe/care on June 27, 2022 at 8:07:17 PM
wrap around transactions.
https://github.com/coronasafe/care/pull/892#issuecomment-1167830051
Shared a comment on a pull request in coronasafe/care on June 27, 2022 at 8:01:55 PM
Approving without testing.
https://github.com/coronasafe/care/pull/831#issuecomment-1167823393
Shared a comment on a pull request in coronasafe/care on June 24, 2022 at 12:58:15 PM
@gigincg please review.
https://github.com/coronasafe/care/pull/877#issuecomment-1165549885
Shared a comment on a pull request in coronasafe/care on June 24, 2022 at 12:58:15 PM
@gigincg please review.
https://github.com/coronasafe/care/pull/877#issuecomment-1165549885
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 1:07:10 PM
resolve the conflicts and we are good to merge.
https://github.com/coronasafe/care/pull/736#issuecomment-1159721881
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 1:00:00 PM
we need to remove references from old migrations as well.
https://github.com/coronasafe/care/pull/822#issuecomment-1159720226
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:52:49 PM
There is something wrong with the migrations, moving to temporary branch to test and push to master.
https://github.com/coronasafe/care/pull/769#issuecomment-1159718454
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:42:00 PM
Can we close this PR is the requirement is already met?
https://github.com/coronasafe/care/pull/829#issuecomment-1159715799
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:39:21 PM
These changes needs to be vetted in detail since there might be a lot of broken references, This PR's review will be delayed.
https://github.com/coronasafe/care/pull/841#issuecomment-1159715146
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:35:54 PM
Try to exclude unrelated changes in the PR, there are settings reconfigurations and some precommit changes in a PR about sentry!.
https://github.com/coronasafe/care/pull/848#issuecomment-1159714201
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:31:32 PM
Changes look good to me otherwise, @mathew-alex add env vars for the extra setting confs required in this PR.
https://github.com/coronasafe/care/pull/791#issuecomment-1159712933
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:12:51 PM
I highly encourage you folks to test with docker-compose, since the docker image is what runs in production, the tests should replicate that environment as much as possible.
https://github.com/coronasafe/care/pull/857#issuecomment-1159708147
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:08:56 PM
@gigincg @aparnacoronasafe Merging this PR will delete all values of HBA1C entered uptill now. Confirm if this is intended.
https://github.com/coronasafe/care/pull/860#issuecomment-1159707099
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 1:07:10 PM
resolve the conflicts and we are good to merge.
https://github.com/coronasafe/care/pull/736#issuecomment-1159721881
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 1:00:00 PM
we need to remove references from old migrations as well.
https://github.com/coronasafe/care/pull/822#issuecomment-1159720226
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:52:49 PM
There is something wrong with the migrations, moving to temporary branch to test and push to master.
https://github.com/coronasafe/care/pull/769#issuecomment-1159718454
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:42:00 PM
Can we close this PR is the requirement is already met?
https://github.com/coronasafe/care/pull/829#issuecomment-1159715799
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:39:21 PM
These changes needs to be vetted in detail since there might be a lot of broken references, This PR's review will be delayed.
https://github.com/coronasafe/care/pull/841#issuecomment-1159715146
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:35:54 PM
Try to exclude unrelated changes in the PR, there are settings reconfigurations and some precommit changes in a PR about sentry!.
https://github.com/coronasafe/care/pull/848#issuecomment-1159714201
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:31:32 PM
Changes look good to me otherwise, @mathew-alex add env vars for the extra setting confs required in this PR.
https://github.com/coronasafe/care/pull/791#issuecomment-1159712933
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:12:51 PM
I highly encourage you folks to test with docker-compose, since the docker image is what runs in production, the tests should replicate that environment as much as possible.
https://github.com/coronasafe/care/pull/857#issuecomment-1159708147
Shared a comment on a pull request in coronasafe/care on June 19, 2022 at 12:08:56 PM
@gigincg @aparnacoronasafe Merging this PR will delete all values of HBA1C entered uptill now. Confirm if this is intended.
https://github.com/coronasafe/care/pull/860#issuecomment-1159707099
Shared a comment on a pull request in coronasafe/care on June 14, 2022 at 2:07:14 PM
We also need an endpoint that returns the current patient/consultation, only accessible by an asset, the data should be of the patient that is connected to the asset via a bed. Only the external_id needs to be returned
https://github.com/coronasafe/care/pull/811#issuecomment-1155235641
Shared a comment on a pull request in coronasafe/care on June 10, 2022 at 6:17:32 PM
I would create a new serializer field that has the empty check validator built-in and use that everywhere instead of re-writing the logic multiple times. Create a PR with this or create an issue to create such a field.
https://github.com/coronasafe/care/pull/838#issuecomment-1152619471
Shared a comment on a pull request in coronasafe/care on June 9, 2022 at 12:43:53 PM
@sainAk the app requires write access to the code, so the app won't be installed. we can keep tabs on it.
https://github.com/coronasafe/care/pull/836#issuecomment-1151073254
Shared a comment on a pull request in coronasafe/care on June 6, 2022 at 2:13:54 PM
Looks like there are no breaking changes, merging without testing.
https://github.com/coronasafe/care/pull/666#issuecomment-1147494681
Shared a comment on a pull request in coronasafe/care on June 6, 2022 at 1:53:07 PM
Closing PR since features are not likely to be merged in ( too many conflicts )
https://github.com/coronasafe/care/pull/619#issuecomment-1147472667
Shared a comment on a pull request in coronasafe/care on June 6, 2022 at 1:51:37 PM
Closing until requirement is open again.
https://github.com/coronasafe/care/pull/578#issuecomment-1147471325
Shared a comment on a pull request in coronasafe/care on June 6, 2022 at 1:37:34 PM
We need pipelines to build HTML. cc @sainAk
https://github.com/coronasafe/care/pull/763#issuecomment-1147457139
Shared a comment on a pull request in coronasafe/care on June 2, 2022 at 2:18:00 PM
@gigincg we can use String choices.
https://github.com/coronasafe/care/pull/793#issuecomment-1144920927
Shared a comment on a pull request in coronasafe/care on May 27, 2022 at 8:58:46 AM
Try to keep changes relevant to the PR only. We also do not recommend force pushes at any point.
https://github.com/coronasafe/care/pull/746#issuecomment-1139422154
Shared a comment on a pull request in coronasafe/care on May 26, 2022 at 11:06:49 AM
you can also add swagger docs by using the fake schema generator that YASG provides
https://github.com/coronasafe/care/pull/762#issuecomment-1138416124
Shared a comment on a pull request in coronasafe/care on May 26, 2022 at 11:01:38 AM
are you sure this wont break the fronend?
https://github.com/coronasafe/care/pull/769#issuecomment-1138412355
Shared a comment on a pull request in coronasafe/care on May 26, 2022 at 10:57:56 AM
yea sure
https://github.com/coronasafe/care/pull/772#issuecomment-1138409685
Shared a comment on an issue in coronasafe/care on May 25, 2022 at 1:18:47 PM
We have another endpoint specifically for this already made.
https://github.com/coronasafe/care/issues/785#issuecomment-1137228438
Shared a comment on an issue in coronasafe/care on May 25, 2022 at 1:15:01 PM
@rabilrbl it's definitely not an issue in code since the whole notification system was working perfectly at some point and no code change was done after that point. can you confirm if this is the issue? If this is an issue, we would also need to do an RCA to figure out why this happened.
https://github.com/coronasafe/care/issues/782#issuecomment-1137224004
Shared a comment on a pull request in coronasafe/care on May 22, 2022 at 9:46:40 AM
Only keep changes relevant to the PR, either remove the other changes or rebase with master if the changes are merged in
https://github.com/coronasafe/care/pull/740#issuecomment-1133858350
Shared a comment on a pull request in coronasafe/care on May 22, 2022 at 9:38:11 AM
@tomahawk-pilot if you are okay then merge this.
https://github.com/coronasafe/care/pull/773#issuecomment-1133856953
Shared a comment on a pull request in coronasafe/care on May 22, 2022 at 9:31:29 AM
@sainAk in FE or BE ?
https://github.com/coronasafe/care/pull/772#issuecomment-1133855793
Shared a comment on a pull request in coronasafe/care on May 22, 2022 at 9:29:48 AM
@sainAk the min_quantity can stay and maybe FE can ignore the flag if the min_quantity value is not present, or we can add that logic into our flagging system.
https://github.com/coronasafe/care/pull/772#issuecomment-1133855548
Shared a comment on a pull request in coronasafe/care on May 22, 2022 at 9:25:58 AM
@tomahawk-pilot is this good to go ?
https://github.com/coronasafe/care/pull/768#issuecomment-1133854752